Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish_clipboard_copy includes a newline #6927

Closed
ariasuni opened this issue Apr 21, 2020 · 4 comments
Closed

fish_clipboard_copy includes a newline #6927

ariasuni opened this issue Apr 21, 2020 · 4 comments
Labels
bug
Milestone
fish 3.1.1

Comments

@ariasuni
Copy link

@ariasuni ariasuni commented Apr 21, 2020

Since commit 2009977, function fish_clipboard_copy adds a \n at the end of the copied text.

I don’t see a good reason for this behavior, and I find it annoying.
@zanchey zanchey added the bug label Apr 21, 2020
@zanchey zanchey added this to the fish-future milestone Apr 21, 2020
@zanchey
Copy link
Member

@zanchey zanchey commented Apr 21, 2020

@faho any thoughts?

@faho faho closed this as completed in 6ebbe5a Apr 21, 2020
@zanchey
Copy link
Member

@zanchey zanchey commented Apr 21, 2020

Yes, apparently :-)

@zanchey zanchey removed this from the fish-future milestone Apr 21, 2020
@zanchey zanchey added this to the fish 3.2.0 milestone Apr 21, 2020
@zanchey zanchey removed this from the fish 3.2.0 milestone Apr 25, 2020
@zanchey zanchey added this to the fish 3.1.1 milestone Apr 25, 2020
@zanchey
Copy link
Member

@zanchey zanchey commented Apr 25, 2020

Took this for 3.1.1 as d9cf1be.

zanchey pushed a commit that referenced this issue Apr 25, 2020
@faho @zanchey
fish_clipboard_copy: Stop adding newlines
d9cf1be 
When this switched over from directly piping commandline to storing
its output and using printf, I inadvertently always added a trailing
newline. That's probably annoying.

Note that this will now always *remove* a trailing newline (because
the command substitution does). That will barely make a
difference (because trailing newlines are quite unusual in the
commandline) and will probably feel better than keeping it - we could
even make a point of removing trailing whitespace in general.

Fixes #6927

(cherry picked from commit 6ebbe5a)
@ariasuni
Copy link
Author

@ariasuni ariasuni commented Apr 25, 2020

Thanks a lot :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
fish 3.1.1
Development

No branches or pull requests
2 participants
@zanchey @ariasuni