Replace command-not-found event with a known function #7293
Labels
Milestone
Comments
|
Sounds good. There's a reasonable number of event handlers in the wild, so perhaps as an initial implementation a |
|
Thankfully this is even easier. To allow overriding, we currently already check for a function of a certain name (because you don't want 2 handlers at the same time): fish-shell/share/functions/__fish_config_interactive.fish Lines 265 to 266 in ee84223 So we can just check that and either call that function or copy it. (i.e. in practice it was already a function of a given name anyway, but I don't want to reuse that name) |
faho
added a commit
to faho/fish-shell
that referenced
this issue
Sep 4, 2020
Previously, when a command wasn't found, fish would emit the
"fish_command_not_found" *event*.
This was annoying as it was hard to override (the code ended up
checking for a function called `__fish_command_not_found_handler`
anyway!), the setup was ugly,
and it's useless - there is no use case for multiple command-not-found handlers.
Instead, let's just call a function `fish_command_not_found` if it
exists, or print the default message otherwise.
The event is completely removed, but because a missing event is not an error
(MEISNAE in C++-speak) this isn't an issue.
Note that, for backwards-compatibility, we still keep the default
handler function around even tho the new one is hard-coded in C++.
Also, if we detect a previous handler, the new handler just calls it.
This way, the backwards-compatible way to install a custom handler is:
```fish
function __fish_command_not_found_handler --on-event fish_command_not_found
# do a little dance, make a little love, get down tonight
end
```
and the new hotness is
```fish
function fish_command_not_found
# do the thing
end
```
Fixes fish-shell#7293.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Fish has long had the
fish_command_not_foundevent that is triggered when a command isn't known.It's always been a bit weird to me that this used the event machinery because
So really, this should just be a function that is invoked by name,
fish_command_not_found, and if that isn't defined the default "fish: command 'choochoo' not found" one should take over.This would also allow us to remove some rather weird logic from __fish_config_interactive and just put it in a normal function file.
The text was updated successfully, but these errors were encountered: