-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Pasting in multi-line prompt causes error in __fish_tokenizer_state #7782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm still seeing this with |
@z3ntu Do check that you have the correct |
Not sure, I'm pretty sure I run proper fish 3.2.1 without any messing up any internal functions myself.. 😉 I do I also have the contents of this commit (also in 3.2.1) installed on my file system 10ef0d9 |
Seems the fix wasn't applied to |
|
Ah, yeah, that's it.
|
Also removes our remaining use of `__fish_commandline_is_singlequoted`. See #7782.
Thanks! Seems |
I'm creating an issue for this for changelog purposes, since it is a regression introduced in 3.2.0
Some of the changes to fish_clipboard_paste in 3.2.0 broke pasting when the command line consisted of more than one line, caused by our old friend the forcible splitting of substituted process output on new lines with no good way to opt out.
e.g.
This would result in an error:
because the output of
(commandline -ct)
is passed to__fish_tokenizer_state
infish_clipboard_paste
, but it is forcibly split on new lines. (I'm pretty sure the exact same underlying process substitution has a lot of other bugs in completions everywhere.)The problem is further exacerbated by the fact that any errors emitted by fish while the prompt is being edited cause corruption of the in-memory terminal state (actual and expected row/cell info differs) meaning that further input at the prompt is not visible or causes corruption of existing content until the screen is cleared (
^L
) or the commandline is repainted (commandline -f repaint
).There was no issue pasting in a multi-line prompt in 3.1.0.
The text was updated successfully, but these errors were encountered: