Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance __fish_print_addresses #7787

Closed
exploide opened this issue Mar 6, 2021 · 2 comments · Fixed by #7793
Closed

Enhance __fish_print_addresses #7787

exploide opened this issue Mar 6, 2021 · 2 comments · Fixed by #7793

Comments

@exploide
Copy link
Contributor

exploide commented Mar 6, 2021

I would like to enhance the function __fish_print_addresses a bit. This function is currently used in completions when something like an address to bind to is required.

It could be enhanced to include the interface name as a description, which would help selecting the correct address.

Besides I would introduce an optional argument like --all that also outputs 0.0.0.0 and ::.

Before conducting a PR: can I just change the existing function or should I create a new one? While a change would not affect the fish codebase, theoretically it's possible that 3rd party scripts use this functions and rely on the fact that no descriptions are included. But if I introduce a new function, the existing one would be unused across the fish codebase.

@krobelus
Copy link
Member

krobelus commented Mar 6, 2021

It's a dundered function, and judging from https://github.com/search?l=&q=__fish_print_addresses&type=code most (or all?) uses
are in completions, where it would only be an improvement to add descriptions. So I think changing the output is fine.

@mqudsi
Copy link
Contributor

mqudsi commented Mar 6, 2021

Dunder is the liquid left in a boiler after distilling a batch of rum. It is a traditional flavor source used in the fermentation of the wash of Jamaican rum.

😂

exploide added a commit to exploide/fish-shell that referenced this issue Mar 7, 2021
added --all flag to include 0.0.0.0 and ::
adapted use of this function in existing completions
fixes fish-shell#7787
@faho faho closed this as completed in #7793 Mar 8, 2021
faho pushed a commit that referenced this issue Mar 8, 2021
added --all flag to include 0.0.0.0 and ::
adapted use of this function in existing completions
fixes #7787
@faho faho modified the milestones: fish-future, fish 3.2.1 Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants