Darkmode for docs and webconfig #8043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emphasizes that they belong together
This makes changing it harder and is unnecessary
This uses the prefers-color-scheme media query to pick between dark and light mode, so the user automatically gets the colorscheme they prefer.
|
I think I like what Dark Reader does a bit more:
The really deep blue background feels rather oppressive, and I prefer a more gray-black than bluish-black. I think that's also more in line with what most text editors use. |
|
One thing I would like to know is how well it works with older sphinx versions - I think there's been a semi-recent change to footnotes? |
|
@IlanCosman How about something more like this I would prefer to keep the blue tint because we also have one in the light version, and it has a bit of a nautical theme. |
Make a bit less ultra-dark blue
|
@faho Much nicer! And I agree with the nautical vibe. I'd say make the background a bit lighter and more blue, and it would be good to go 😄 |
faho
added a commit
to faho/fish-site
that referenced
this pull request
Jun 6, 2021
The colors are roughly the same as in fish-shell/fish-shell#8043. One fly in the ointment is that the distro logos don't look good on a dark background, so we add a cheesy white background to them.
faho
added a commit
to faho/fish-site
that referenced
this pull request
Jun 9, 2021
The colors are roughly the same as in fish-shell/fish-shell#8043. One fly in the ointment is that the distro logos don't look good on a dark background, so we add a cheesy white background to those that need it.
faho
added a commit
to fish-shell/fish-site
that referenced
this pull request
Jun 9, 2021
The colors are roughly the same as in fish-shell/fish-shell#8043. One fly in the ointment is that the distro logos don't look good on a dark background, so we add a cheesy white background to those that need it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the prefers-color-scheme media query to choose between a dark and a light colorscheme for both the docs and fish_config. It's pure css, no script or anything.
To see the changes, you'll have to set your dark mode preference or open up the devtools and force-enable it there. Firefox on linux should "just work" if you have a dark system colorscheme, chromium needs to be started as
chromium --force-dark-mode.Some screenshots:
fish_config
The docs
TODOs: