Fuzzy completion broke some wildcard completions

[lledey]

Commit 908b075 implementing fuzzy completions broke some wildcard completions.

For example :
ls *.<tab>

Instead of printing all file extensions, fish_pager is called with an empty list of possible completions and the only way to quit is to type ctrl+c.

[terlar]

I also experience this problem.

[ridiculousfish]

I think the issue is here, in wildcard.cpp:

    /* Try all submatches */
    do
    {
        res = wildcard_complete_internal(orig, str, wc+1, 0, desc, desc_func, out, expand_flags, flags);
        if (res)
            break;
    }

We exit out of the loop as soon as we get any matches. But the fuzzy matching means that for example 'foo.jpg' matches "." as a substring match, so we stop there. The fix would be to get rid of the early-out.

[ridiculousfish]

This might have some nasty performance implications if the string is long and there are multiple wildcards. There's also a duplication issue:

> echo f*o*<tab>
f*o*.jpg f*o*o.jpg

[ridiculousfish]

bash seems to expand wildcards on tab complete. zsh refuses to tab complete in some cases.

[ridiculousfish]

This should be much improved with ee3b355

Thanks for reporting this!

[lledey]

Great, thanks !