Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zabbix completions #9647

Merged
merged 4 commits into from Apr 1, 2023
Merged

Add Zabbix completions #9647

merged 4 commits into from Apr 1, 2023

Conversation

szuro
Copy link
Contributor

@szuro szuro commented Mar 8, 2023

Description

Adds completions for Zabbix commands

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

ridiculousfish
ridiculousfish requested changes Mar 11, 2023
View reviewed changes
share/completions/zabbix_agentd.fish Show resolved Hide resolved
share/completions/zabbix_proxy.fish Outdated Show resolved Hide resolved
share/completions/zabbix_server.fish Outdated Show resolved Hide resolved
mqudsi
mqudsi requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mqudsi mqudsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this but some of your descriptions are too long. Descriptions don't get a lot of room in the pager, can you please trim them down to around 50 chars or so max? They don't have to be full sentences.

@szuro
Copy link
Contributor Author

szuro commented Mar 22, 2023

Shortened some of the descriptions

@mqudsi mqudsi added this to the fish 3.6.2 milestone Apr 1, 2023
@mqudsi mqudsi merged commit 9bd1dc1 into fish-shell:master Apr 1, 2023
6 of 7 checks passed
faho pushed a commit that referenced this pull request Sep 8, 2023
@szuro @faho
Add Zabbix completions (#9647)
de5bd62 
Add Zabbix completions

(cherry picked from commit 9bd1dc1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqudsi mqudsi mqudsi requested changes

@ridiculousfish ridiculousfish ridiculousfish requested changes

Assignees
No one assigned
Labels
completions
Projects
None yet
Milestone
fish 3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szuro @mqudsi @ridiculousfish @zanchey