Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation is clipped on right side #9690

Closed
robfordww opened this issue Mar 23, 2023 · 2 comments
Closed

Documentation is clipped on right side #9690

robfordww opened this issue Mar 23, 2023 · 2 comments
Labels
bug Something that's not working as intended docs An issue/PR that touches or should touch the docs
Milestone
fish 3.7.0

Comments

@robfordww
Copy link

When using latest chrome and edge on Android 14, the right hand side of most documentation pages are clipped, preventing me from reading the last part of most lines.

See this screenshot for example:

Screenshot_2023-03-23-11-17-47-53_40deb401b9ffe8e1df2f1cc5ba480b12
@zanchey zanchey transferred this issue from fish-shell/fish-site Mar 27, 2023
@zanchey zanchey added bug Something that's not working as intended docs An issue/PR that touches or should touch the docs labels Mar 27, 2023
@zanchey zanchey added this to the fish-future milestone Mar 27, 2023
@faho
Copy link
Member

faho commented Mar 27, 2023

Yup, it's missing a width: 100%; for div.documentwrapper in the CSS - this was missing from #9003.

I think we can just upload this straight to the site, no real need to make a release for it.

@faho faho closed this as completed in ca02e88 Mar 27, 2023
faho added a commit to fish-shell/fish-site that referenced this issue Mar 27, 2023
@faho
docs: Prevent overflow for narrow screens
86c7bed 
Backport from fish-shell/ca02e88ef

See fish-shell/fish-shell#9690
@faho
Copy link
Member

faho commented Mar 27, 2023

Fixed and deployed as fish-shell/fish-site@86c7bed

(tagging for 3.6.2)

@faho faho modified the milestones: fish-future, fish 3.6.2 Mar 27, 2023
faho added a commit that referenced this issue Sep 8, 2023
@faho
docs: Prevent overflow for narrow screens
252f521 
Regression from #9003, this is visible on mobile mainly.

Fixes #9690

(cherry picked from commit ca02e88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended docs An issue/PR that touches or should touch the docs
Projects
None yet
Milestone
fish 3.7.0
Development

No branches or pull requests
3 participants
@zanchey @faho @robfordww