Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horcrux completion #9922

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Jul 29, 2023

Description

https://github.com/jesseduffield/horcrux

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Notes

For some reason, options are passed before split subcommand. As @faho responded in Gitter it's not the way Fish completions should work.

@faho faho added this to the fish 3.7.0 milestone Aug 9, 2023
@faho faho merged commit f9d21cc into fish-shell:master Aug 9, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Aug 9, 2023

Merged, thanks!

faho pushed a commit that referenced this pull request Oct 6, 2023
* feat(completions): horcrux

* feat(changelog): mention completion

* fix(completion): condition for -n

(cherry picked from commit f9d21cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants