Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add completions for crc and oc #10034

Merged
merged 2 commits into from Oct 1, 2023
Merged

Conversation

kfkonrad
Copy link
Contributor

@kfkonrad kfkonrad commented Sep 29, 2023

Description

This PR adds completions for crc to fish. crc (Code Ready Containers) is a RedHat tool for using OpenShift locally. It provides autogenerated and (as far as I've been able to tell so far) accurate completions. This PR merely sources those completions.

I'll add the issue number to the Changelog once the PR is created. Done

EDIT: after seeing that the oc completions are missing I've added those as well.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@kfkonrad kfkonrad changed the title add completions for crc add completions for crc and co Sep 29, 2023
@kfkonrad kfkonrad changed the title add completions for crc and co add completions for crc and oc Sep 29, 2023
@faho faho added this to the fish 3.7.0 milestone Oct 1, 2023
@faho faho merged commit 269c9c3 into fish-shell:master Oct 1, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Oct 1, 2023

Thanks!

faho pushed a commit that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants