Skip to content

add completions for crc and oc#10034

Merged
faho merged 2 commits intofish-shell:masterfrom
kfkonrad:feature/crc-completion
Oct 1, 2023
Merged

add completions for crc and oc#10034
faho merged 2 commits intofish-shell:masterfrom
kfkonrad:feature/crc-completion

Conversation

@kfkonrad
Copy link
Contributor

@kfkonrad kfkonrad commented Sep 29, 2023

Description

This PR adds completions for crc to fish. crc (Code Ready Containers) is a RedHat tool for using OpenShift locally. It provides autogenerated and (as far as I've been able to tell so far) accurate completions. This PR merely sources those completions.

I'll add the issue number to the Changelog once the PR is created. Done

EDIT: after seeing that the oc completions are missing I've added those as well.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@kfkonrad kfkonrad force-pushed the feature/crc-completion branch from 3c49875 to 46c8b9e Compare September 29, 2023 08:54
@kfkonrad kfkonrad changed the title add completions for crc add completions for crc and co Sep 29, 2023
@kfkonrad kfkonrad changed the title add completions for crc and co add completions for crc and oc Sep 29, 2023
@faho faho added this to the fish 3.7.0 milestone Oct 1, 2023
@faho faho merged commit 269c9c3 into fish-shell:master Oct 1, 2023
@faho
Copy link
Member

faho commented Oct 1, 2023

Thanks!

faho pushed a commit that referenced this pull request Oct 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments