Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log original exit code used when a builtin returns a negative exit code #10187

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Jan 3, 2024

Description

In fish 3.7.0 executing exit with a negative argument results in:

$ fish -c 'exit -123'
warning: builtin exit returned invalid exit code 133

It would make more sense if the error was:

$ fish -c 'exit -123'
warning: builtin exit returned invalid exit code -123

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added this to the fish next-3.x milestone Jan 4, 2024
@faho faho merged commit b91723d into fish-shell:Integration_3.7.0 Jan 4, 2024
5 of 6 checks passed
@faho
Copy link
Member

faho commented Jan 4, 2024

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants