Skip to content

Conversation

@tyilo
Copy link
Contributor

@tyilo tyilo commented Jan 3, 2024

Description

In fish 3.7.0 executing exit with a negative argument results in:

$ fish -c 'exit -123'
warning: builtin exit returned invalid exit code 133

It would make more sense if the error was:

$ fish -c 'exit -123'
warning: builtin exit returned invalid exit code -123

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added this to the fish next-3.x milestone Jan 4, 2024
@faho faho merged commit b91723d into fish-shell:Integration_3.7.0 Jan 4, 2024
@faho
Copy link
Member

faho commented Jan 4, 2024

Makes sense, thanks!

@faho faho modified the milestones: fish next-3.x, fish 3.7.1 Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants