Always source file after funced
#10318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... even if the file hasn't changed. This addresses an oddity in the following case: * Shell is started, * function `foo` is sourced from foo.fish * foo.fish is *externally* edited and saved * <Loaded definition of `foo` is now stale, but fish is unaware> * `funced foo` loads `type -p foo` showing changed definition, user exits $EDITOR saving no changes (or with $status 0, more generally). * Stale definition of `foo` remains
zanchey
approved these changes
Feb 21, 2024
faho
pushed a commit
that referenced
this pull request
Mar 13, 2024
... even if the file hasn't changed. This addresses an oddity in the following case: * Shell is started, * function `foo` is sourced from foo.fish * foo.fish is *externally* edited and saved * <Loaded definition of `foo` is now stale, but fish is unaware> * `funced foo` loads `type -p foo` showing changed definition, user exits $EDITOR saving no changes (or with $status 0, more generally). * Stale definition of `foo` remains (cherry picked from commit 2c2ab0c)
vertesians
pushed a commit
to vertesians/fish-shell
that referenced
this pull request
Apr 17, 2024
Regressed in 2c2ab0c (Always `source` file after `funced` (fish-shell#10318), 2024-02-22) which was only intended for functions that are backed by a file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... even if the file hasn't changed. This addresses an oddity in the following case:
foois sourced from foo.fishfoois now stale, but fish is unaware>funced fooloadstype -p fooshowing changed definition, user exits $EDITOR saving no changes (or with $status 0, more generally).fooremains