Try to add 'completions' label to PRs automatically #10515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqudsi
force-pushed
the
auto_label_prs
branch
6 times, most recently
from
456dd52
to
6a96a4e
Compare
|
One approach to testing is to use your fork - does mean you need to turn issues/PRs on temporarily but I think it can even be done in a private fork |
|
Trying that now. I have to merge this into my |
The desired behavior is for a PR that modifies share/completions/*.fish and does not modify any other paths except ignoring changes to share/functions/*.fish gets a 'completions' label. (There's another approach I was looking at first that can automatically set the 'fish next-3.x' milestone as well by doing all this manually via the api instead of using the labeler@v5 action, but it requires setting up GitHub secret tokens and I don't feel like doing that right now.)
|
Got this working in 53eeb8a but I was nerd-sniped into figuring out how to set the milestone too so I'm opening up a new PR that does both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desired behavior is for a PR that modifies share/completions/.fish and does not modify any other paths except ignoring changes to share/functions/.fish gets a 'completions' label.
(There's another approach I was looking at first that can automatically set the 'fish next-3.x' milestone as well by doing all this manually via the api instead of using the labeler@v5 action, but it requires setting up GitHub secret tokens and I don't feel like doing that right now.)
I'm not sure how to test this 😅