Fish spec

[bpinto]

@bucaran and I created this plugin called fish-spec to test oh-my-fish internals and plugins.

This is fish-spec running tests on verbose mode:

The aim of this pull request is to discuss the introduction of fish-spec as a dependency to fish-shell tests so that we can start writing tests in an easier way to understand than we currently do (test1.in, test1.out).

P.S.: The only interesting commit to be seen is the last one.

[bpinto]

math requires bc package. Check: #1905

[bpinto]

This is the output of the added tests, with and without verbose mode.

[ghost]

Sometimes mistakes happen, and here is how the output looks like then.

[krader1961]

@bpinto and @bucaran: This pull-request is now more than a year old and the https://github.com/bpinto/oh-my-fish/tree/master/plugins/fish-spec link no longer works. Is this still something you'd like to see merged? If yes would you mind opening an enhancement issue that describes the problem and your solution?

[ghost]

Is this still something you'd like to see merged?

Not me. I am using Fishtape to write my tests now, and not working in fish-spec anymore.

[krader1961]

I'd love to see a framework for fish unit tests in the same vein as Python's unittest2. There are some intriguing ideas in this change but also some problems (like the "it_supports_" naming scheme and redefining expect as a function). Given that no one else has advocated for adopting this in over a year I think it's time to close this and go back to the drawing board.

[ghost]

@krader1961 Have you had a look at Fishtape? I certainly took inspiration from unittest2.

Tests look like this:

test "math still works"
    5 -eq (math 2 + 3)
end

test "grep still finds"
    dog = (printf "%s\n" $animals | grep dog)
end

test "file exists"
    -f $my_file
end