Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysctl completion #2214

Closed
wants to merge 2 commits into from
Closed

Add sysctl completion #2214

wants to merge 2 commits into from

Conversation

faho
Copy link
Member

@faho faho commented Jul 16, 2015

See #1375

I'm not sure about the deprecated/aliased options - if I include them, that makes the output longer for things that do the same, but not including them means people have to read the man page if they've gotten the invocation from somewhere else to find out what they mean.

@faho faho mentioned this pull request Jul 16, 2015
@zanchey
Copy link
Member

zanchey commented Jul 17, 2015

This doesn't work on OS X 😞 see #1745 for more.

@faho
Copy link
Member Author

faho commented Jul 17, 2015

I just attempted to add support for OSX's weird implementation. The best way I could see was to just try sysctl -h, which OSX sysctl doesn't seem to support, so it should fail and allow us to use a completely different completion (as they are).

It also uses ":" as a key/value separator, so my assumption was that the output of sysctl -a looks like:

flounder:flat

Do note that I DID NOT TEST THIS as I don't have an OSX machine, I purely followed the comments and the manpage.

@ridiculousfish
Copy link
Member

Looks good on OS X. Thanks for this! Merged as f359ded.

@zanchey zanchey added this to the next-2.x milestone Jul 23, 2015
@faho faho added the release notes Something that is or should be mentioned in the release notes label Oct 26, 2015
@faho faho deleted the sysctl-completion branch December 16, 2015 18:10
ridiculousfish added a commit that referenced this pull request Sep 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
completions enhancement release notes Something that is or should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants