Have funced check VISUAL as well as EDITOR. #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just committed a slightly different solution. Please let me know if you are unhappy with that. |
faho
added a commit
to faho/fish-shell
that referenced
this pull request
Sep 8, 2015
faho
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both VISUAL and EDITOR are used for setting the preferred editor. Various applications disagree about which should be used, and there are examples that use either one and not the other. Recommended practice for users is to set them both to the same thing.
However, not everyone does that, so checking them both is a bit friendlier. Since VISUAL is usually the preferred editor when they are different, it should be checked first.