Improve situation for linux in-kernel VTs (TERM = "linux") #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a special colorscheme and prompt function guaranteed to work on a VT and activates them automatically if $TERM = "linux". set_color is overridden to only allow the 8 colors VTs have (under the assumption those are always the same) and the color variables are shadowed with global ones so they don't pollute our nice capable terms.
|
I've now merged this as f71e877 since nobody objected. |
| set -g fish_color_operator cyan | ||
| set -g fish_color_quote blue | ||
| set -g fish_color_autosuggestion yellow | ||
| set -g fish_color_valid_path |
There was a problem hiding this comment.
Is there supposed to be an argument here?
There was a problem hiding this comment.
There probably should be. The default happens to not break, though.
|
It seems that this has broken |
|
See 40df11b - bold actually works, underlines don't break anything and printing colors is... well, printing not setting. |
|
That fix the bold, but there is an still error for background. |
|
I could have sworn that background doesn't work, but apparently it does. See b231ab7. |
|
_Bingo!_ It is working now. Good luck and have a nice day! |
faho
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special colorscheme and prompt function (a clone of the "classic" prompt) guaranteed to work
on a VT and activates them automatically if $TERM = "linux".
set_color is overridden to only allow the 8 colors VTs have (under the
assumption those are always the same) and the color variables are
shadowed with global ones so they don't pollute our nice capable terms.
Fixes #2070.
Everyone okay with the approach or should we bend over backwards even harder?