-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation #3247
Fix documentation #3247
Conversation
Restores erroneous changes to lexicon_filter and changes to doc_src/ pages. Done by hand to ensure version history. Fixes display of % when misinterpreted by Doxygen.
Only found one instance, which I’d already identified.
I'm still getting the warnings I mentioned encountering in #3198 with Doxygen I want to just escape whatever it mentions, wherever I find it... but I get nervous as I've messed that up before when the strings shouldn't have reached that stage of the process.
make doc (entire output below)
|
I just installed Doxygen from HEAD and see the same warnings. As the warnings are being generated from items within backticks and escaping them causes double backticks I've checked through the documentation and there are no changes since 1.8.7 that could be affecting this. Despite the warnings, is the output correct? Try installing the last official release 1.8.11? |
1.8.11 is fine here. I'm happy if you say so! Was hoping that this was just a doxygen bug. |
Although -
No - the |
Yep - it's the same here for HEAD. Once it hits the first error it's not breaking out of the fenced code block correctly. Digging deeper it's happening inside Doxygen's rendering process (which uses 2 passes when Markdown is enabled). This is evidenced by the fact that the reported line numbers for doc.h don't match the source. I'll keep an eye on it as Doxygen approaches cutting its next release, but their HEAD is more of a work-in-progress compared to fish's. |
Merged. We can't thank you enough @MarkGriffiths for your help with the documentation issues. |
Fix documentation
Description
Fixes issue #3197 and fish-shell/fish-site#40
Supersedes #3198
TODOs:
Tests have been added for regressions fixedn/a