fix error when completing vi if it didnt exist #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| complete -c vi -r -s t --description 'Edit the file containing a tag' | ||
| complete -c vi -r -c t --description 'Begin editing by executing the specified editor command' | ||
| # Check if vi exists at all ( needed for vi --version ) | ||
| if type vi > /dev/null ^ /dev/null |
There was a problem hiding this comment.
Fixed, changed to type -q
|
Not really a crash, but probably worthwhile. |
Cobrand
changed the title
|
Thanks, merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If vi wasn't in the OS by default, invoking completion with vi instantiated an error :
This commit fixed that by checking if 'vi' exists with the 'type' command beforehand