auto-complete for sysbench (0.4.12) #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SysBench is a modular, cross-platform and multi-threaded benchmark tool for evaluating OS parameters that are important for a system running a database under intensive load
faho
requested changes
Oct 26, 2016
|
|
||
| ### sub commands specification ### | ||
| complete -c sysbench -f -a "run\t'Run the test'" | ||
| complete -c sysbench -n "__fish_contains_opt test=fileio" -a " |
There was a problem hiding this comment.
I'm willing to bet that sysbench --test fileio is also valid, which this won't recognize. You probably want to write a function that iterates over commandline -opc and checks if either --test=$argv is in there or there's a token test, followed by $argv.
|
Surprisingly, Sysbench long options only work with equal sign. So that code is correct, and represents current state of the things. That said, I'll check with Sysbench authors, send patch to fix it. But that's a different story. |
|
Merged, thanks! If sysbench ever gets support for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey! I've added auto-complete for sysbench:
Please take a look, and if you find it useful - merge it.
You can find manual page for it here: http://man.cx/sysbench(1)
Thanks!