Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-complete for sysbench (0.4.12) #3491

Merged
merged 1 commit into from Nov 4, 2016
Merged

auto-complete for sysbench (0.4.12) #3491

merged 1 commit into from Nov 4, 2016

Conversation

@manzur
Copy link
Contributor

manzur commented Oct 25, 2016

Description

Hey! I've added auto-complete for sysbench:

SysBench is a modular, cross-platform and multi-threaded benchmark tool for
evaluating OS parameters that are important for a system running a database
under intensive load

Please take a look, and if you find it useful - merge it.
You can find manual page for it here: http://man.cx/sysbench(1)

Thanks!

SysBench is a modular, cross-platform and multi-threaded benchmark tool for
evaluating OS parameters that are important for a system running a database
under intensive load

### sub commands specification ###
complete -c sysbench -f -a "run\t'Run the test'"
complete -c sysbench -n "__fish_contains_opt test=fileio" -a "

This comment has been minimized.

@faho

faho Oct 26, 2016 Member

I'm willing to bet that sysbench --test fileio is also valid, which this won't recognize. You probably want to write a function that iterates over commandline -opc and checks if either --test=$argv is in there or there's a token test, followed by $argv.

@manzur
Copy link
Contributor Author

manzur commented Oct 26, 2016

Surprisingly, Sysbench long options only work with equal sign. So that code is correct, and represents current state of the things. That said, I'll check with Sysbench authors, send patch to fix it. But that's a different story.

@faho faho merged commit 00a8766 into fish-shell:master Nov 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho
Copy link
Member

faho commented Nov 4, 2016

Merged, thanks!

If sysbench ever gets support for --longoption argument, we can add that.

@faho faho added this to the next-2.x milestone Nov 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.