Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an invalid flag to `function` is handled wrong #3574

Closed
wants to merge 1 commit into from

Conversation

@krader1961
Copy link
Contributor

krader1961 commented Nov 21, 2016

Specifically, an invalid flag keeps the function from being defined but
does not emit an error message.

Fixes #2827

Specifically, an invalid flag keeps the function from being defined but
does not emit an error message.

Fixes #2827
@krader1961 krader1961 added the bug label Nov 23, 2016
@krader1961 krader1961 added this to the fish 2.5.0 milestone Nov 23, 2016
@krader1961
Copy link
Contributor Author

krader1961 commented Nov 23, 2016

Closed with merge of commit 320cb68.

@krader1961 krader1961 closed this Nov 23, 2016
@faho faho added the release notes label Dec 2, 2016
@krader1961 krader1961 deleted the krader1961:function-invalid-flag branch Jan 15, 2017
@hauleth
Copy link
Contributor

hauleth commented Feb 7, 2017

There is one issue, currently it is impossible to define function with name - which was legal previously. This really bothers me as there is no alternative to that #709 was never accepted and provide non uniform feel when using auto chdir.

@krader1961
Copy link
Contributor Author

krader1961 commented Feb 7, 2017

@hauleth: The solution is to use an abbreviation: abbr -a -- - 'cd -'.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.