an invalid flag to `function` is handled wrong #3574

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@krader1961
Contributor

krader1961 commented Nov 21, 2016

Specifically, an invalid flag keeps the function from being defined but
does not emit an error message.

Fixes #2827

an invalid flag to `function` is handled wrong
Specifically, an invalid flag keeps the function from being defined but
does not emit an error message.

Fixes #2827

@krader1961 krader1961 added the bug label Nov 23, 2016

@krader1961 krader1961 added this to the fish 2.5.0 milestone Nov 23, 2016

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Nov 23, 2016

Contributor

Closed with merge of commit 320cb68.

Contributor

krader1961 commented Nov 23, 2016

Closed with merge of commit 320cb68.

@krader1961 krader1961 closed this Nov 23, 2016

@faho faho added the release notes label Dec 2, 2016

@krader1961 krader1961 deleted the krader1961:function-invalid-flag branch Jan 15, 2017

@Konstruktionist Konstruktionist referenced this pull request in jichu4n/fish-command-timer Feb 4, 2017

Closed

Fish 2.5 gives an error #13

@hauleth

This comment has been minimized.

Show comment
Hide comment
@hauleth

hauleth Feb 7, 2017

Contributor

There is one issue, currently it is impossible to define function with name - which was legal previously. This really bothers me as there is no alternative to that #709 was never accepted and provide non uniform feel when using auto chdir.

Contributor

hauleth commented Feb 7, 2017

There is one issue, currently it is impossible to define function with name - which was legal previously. This really bothers me as there is no alternative to that #709 was never accepted and provide non uniform feel when using auto chdir.

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Feb 7, 2017

Contributor

@hauleth: The solution is to use an abbreviation: abbr -a -- - 'cd -'.

Contributor

krader1961 commented Feb 7, 2017

@hauleth: The solution is to use an abbreviation: abbr -a -- - 'cd -'.

@arbourd arbourd referenced this pull request in fisherman/fishtape Jun 9, 2017

Merged

Removes comments from `functions` output #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment