Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to rename abbreviations #3610

Closed
wants to merge 1 commit into from

Conversation

@radomirbosak
Copy link
Contributor

radomirbosak commented Dec 1, 2016

Description

The abbr function doesn't have the possiblity to rename abbreviations.
You have to delete the old one and create a new one. This commit adds
this functionality and uses the syntax:

abbr -r OLD_KEY NEW_KEY

Fixes issue #2155 .

TODOs:

  • Changes to fish usage are reflected in user documenation/manpages.
  • Tests have been added
The abbr function doesn't have the possiblity to rename abbreviations.
You have to delete the old one and create a new one. This commit adds
this functionality and uses the syntax:

abbr -r OLD_KEY NEW_KEY

Fixes #2155.
@krader1961
Copy link
Contributor

krader1961 commented Dec 1, 2016

Excellent work. Thank you for taking the trouble to add unit tests. I tweaked the style of one tiny section of the code to reflect our preference for early returns with the main logic not nested inside a block if that isn't otherwise needed. Merged as commit 1fbcb1e.

@krader1961 krader1961 closed this Dec 1, 2016
@krader1961 krader1961 added this to the fish 2.5.0 milestone Dec 1, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.