Add the possibility to rename abbreviations #3610

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@radomirbosak
Contributor

radomirbosak commented Dec 1, 2016

Description

The abbr function doesn't have the possiblity to rename abbreviations.
You have to delete the old one and create a new one. This commit adds
this functionality and uses the syntax:

abbr -r OLD_KEY NEW_KEY

Fixes issue #2155 .

TODOs:

  • Changes to fish usage are reflected in user documenation/manpages.
  • Tests have been added
Add the possibility to rename abbreviations
The abbr function doesn't have the possiblity to rename abbreviations.
You have to delete the old one and create a new one. This commit adds
this functionality and uses the syntax:

abbr -r OLD_KEY NEW_KEY

Fixes #2155.
@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Dec 1, 2016

Contributor

Excellent work. Thank you for taking the trouble to add unit tests. I tweaked the style of one tiny section of the code to reflect our preference for early returns with the main logic not nested inside a block if that isn't otherwise needed. Merged as commit 1fbcb1e.

Contributor

krader1961 commented Dec 1, 2016

Excellent work. Thank you for taking the trouble to add unit tests. I tweaked the style of one tiny section of the code to reflect our preference for early returns with the main logic not nested inside a block if that isn't otherwise needed. Merged as commit 1fbcb1e.

@krader1961 krader1961 closed this Dec 1, 2016

@krader1961 krader1961 added this to the fish 2.5.0 milestone Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment