New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Magento2 CLI completions #4043

Merged
merged 4 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@Radiergummi
Contributor

Radiergummi commented May 18, 2017

Description

This is the completion file for the Magento2 CLI application I use on my servers. It has an additional feature tho, I'm not sure if it fits into the fish completion philosophy:
If you provide limited access credentials, it will connect to the MySQL database and provide additional suggestions, such as available users, themes or indexers in the database. If this file is never touched, those suggestions simply won't show up. I, personally, find them to be pretty useful, though.

Should I remove those database suggestions before creating a PR?

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
Added Magento2 CLI completions
This is the completion file for the Magento2 CLI application I use on my servers. It has an additional feature tho, I'm not sure if it fits into the fish completion philosophy:  
If you provide limited access credentials, it will connect to the MySQL database and provide additional suggestions, such as available users, themes or indexers in the database. If this file is never touched, those suggestions simply won't show up. I, personally, find them to be pretty useful, though.  

Should I remove those database suggestions before creating a PR?
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho May 18, 2017

Member

Should I remove those database suggestions before creating a PR?

Yes, please. Approximately one person (i.e. you) is going to use that, so the code will just rot.

I'll add other comments inline.

Member

faho commented May 18, 2017

Should I remove those database suggestions before creating a PR?

Yes, please. Approximately one person (i.e. you) is going to use that, so the code will just rot.

I'll add other comments inline.

Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated
Show outdated Hide outdated share/completions/magento.fish Outdated

Radiergummi added some commits May 18, 2017

Improved descriptions
Tried to shorten the text as much as possible and removed unnecessary characters
@faho

faho approved these changes May 18, 2017

@faho faho added this to the 2.6.0 milestone May 18, 2017

@faho faho merged commit 71f5fe1 into fish-shell:master May 18, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho May 18, 2017

Member

Merged, thanks!

@zanchey: This is good for 2.6.0.

Member

faho commented May 18, 2017

Merged, thanks!

@zanchey: This is good for 2.6.0.

zanchey added a commit that referenced this pull request May 19, 2017

Added Magento2 CLI completions (#4043)
* Added Magento2 CLI completions

This is the completion file for the Magento2 CLI application I use on my servers. It has an additional feature tho, I'm not sure if it fits into the fish completion philosophy:
If you provide limited access credentials, it will connect to the MySQL database and provide additional suggestions, such as available users, themes or indexers in the database. If this file is never touched, those suggestions simply won't show up. I, personally, find them to be pretty useful, though.

Should I remove those database suggestions before creating a PR?

* Removed functions using MySQL, updated formatting

* Several smaller fixes

* Improved descriptions

Tried to shorten the text as much as possible and removed unnecessary characters

(cherry picked from commit 71f5fe1)
@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey May 19, 2017

Member

Thanks, taken for 2.6.0 as 291d88a.

Member

zanchey commented May 19, 2017

Thanks, taken for 2.6.0 as 291d88a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment