-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completions for mdadm #4198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No literal tabs, use \t.
The rest seems nice.
share/completions/mdadm.fish
Outdated
# as their absence has already been checked, because this absence caused evaluation of __fish_not_contain_opt | ||
|
||
function __fish_mdadm_metadata_options | ||
echo "0 Use original 0.90 format superblock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these literal tab characters?
I'd prefer it if we used the \t
escape instead.
It's even possible to use something like
printf '%s\t%s\n' "0" "Use original 0.90 format superblock" \
"0.90" "Use original 0.90 format superblock"
# and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, a bit simpler:
echo "0"\t"Use original 0.90 format superblock"
echo "0.90"\t"..."
or countless variations. Anyway, please use \t
, no tab characters in our files if we can help it.
Here you are. |
And there you are - merged, thanks! |
Description
This PR adds completions for
mdadm
, the Linux tool for maintaining software RAID. This has been developed using theman
page, so it should be rather exhaustive, taking into account around 98% of use cases AFAIK, but there could be some lacks due to:mdadm
idiosyncrasies, like using the same short option for several long ones, or their different meanings in different contexts,man
, being only a regularmdadm
user, not an expert,TODOs: