New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for mdadm #4198

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
3 participants
@PenegalECI
Contributor

PenegalECI commented Jul 7, 2017

Description

This PR adds completions for mdadm, the Linux tool for maintaining software RAID. This has been developed using the man page, so it should be rather exhaustive, taking into account around 98% of use cases AFAIK, but there could be some lacks due to:

  • mdadm idiosyncrasies, like using the same short option for several long ones, or their different meanings in different contexts,
  • a misunderstanding of the man, being only a regular mdadm user, not an expert,
  • some specific combination of tags,
  • remaining bugs or typos, although I checked my code along the whole coding.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
@faho

faho requested changes Jul 7, 2017 edited

No literal tabs, use \t.

The rest seems nice.

Show outdated Hide outdated share/completions/mdadm.fish Outdated

@faho faho added the completions label Jul 7, 2017

@faho faho added this to the fish 2.7.0 milestone Jul 7, 2017

@krader1961

This comment has been minimized.

Show comment
Hide comment
@krader1961

krader1961 Jul 9, 2017

Contributor

I agree with @faho. Do not include literal tabs (or other non-printable chars) in those strings since they are effectively invisible. Please use a symbolic representation like \t as @faho suggested so that it is obvious to anyone reading the script they are present.

Contributor

krader1961 commented Jul 9, 2017

I agree with @faho. Do not include literal tabs (or other non-printable chars) in those strings since they are effectively invisible. Please use a symbolic representation like \t as @faho suggested so that it is obvious to anyone reading the script they are present.

@PenegalECI

This comment has been minimized.

Show comment
Hide comment
@PenegalECI

PenegalECI Jul 10, 2017

Contributor

Here you are.

Contributor

PenegalECI commented Jul 10, 2017

Here you are.

@faho faho merged commit c577d01 into fish-shell:master Jul 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Jul 10, 2017

Member

And there you are - merged, thanks!

Member

faho commented Jul 10, 2017

And there you are - merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment