Completions for snap

[radek-sprta]

Description

Basic completions for snap. Still need to work out quirks with couple of the commands. Putting this here for feedback.

TODOs:

• Changes to fish usage are reflected in user documentation/manpages.
• Tests have been added for regressions fixed
• User-visible changes noted in CHANGELOG.md

[zanchey]

I'd suggest using the string builtin here, and throughout the completion where you use grep/cut etc.

[radek-sprta]

Ok, switched to string everywhere.

[radek-sprta]

I ran into an issue with the snap connect/disconnect subcommands. The argument order is snap connect snap:interface.
I got it working to the point where it gives completions for snap and interface and results in snap connect snap: interface. Any idea how to get rid of the space after colon, that gets inserted after choosing a completion from the dropdown menu?

[faho]

The argument order is snap connect snap:interface.

So you mean the snap:interface is one token? Fish's completion works on one token at a time. What you want here is something like

complete -f -c snap -n '__fish_snap_using_subcommand connect' -a '(__fish_snap_connectable_snaps):(__fish_snap_interfaces)'

The two command substitutions will be combined in a cartesian product, so this should result in the correct thing.

If this however results in too many candidates, you can use commandline -ct and string match to check if there's a ":" in the current token. However, you then need to print the complete resulting token (e.g. printf '%s\n' (string replace -r '.*:' '' -- $token):(__fish_snap_interfaces)).

[radek-sprta]

Thanks for the swift answer!
The Cartesian product would be too big I think (I was surprised how many interfaces were added since I last used snap), but I will try the second approach tonight.

[radek-sprta]

Should be feature complete now.

[krader1961]

Squash merged as commit 74cac0f. Thx.