Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
@faho thanks for reviewing; I knew there would be a significant amount of feedback if I opened this a PR rather than merging directly despite the fact that it works.
I had a hard time finding a good reference on the best practices for writing completions and each completion file I looked at was different than the other (though of course I didn't go through too many). Perhaps we can add a more-indepth article about writing completions to the online resources, as the existing seemed to only cover the very basic usage of
I didn't look at the completions for sysctl, I tried to base mine off of
It doesn't seem like it should be too hard to take these suggestions into account (I'm going to hold off on
Yes, they are. They were written at different times by different people. Obviously I prefer my own style.
That would be nice to have, yes.
The completions for it are nice (except for the use of
Yes. You can push directly to Integration_2.7.0 if you want - no need to review again, unless you prefer that. In its current state this is okay, my objections are stylistic.