Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redirect to / in status.in/err test. #4335

Closed

Conversation

gyakovlev
Copy link
Contributor

Description

I was running fish test and this is the only test failing under sandboxed environment Gentoo linux uses during build/test process.
It does not allow to write outside of sandbox so >/ redirect is failing.
Trying to redirect something to / looks a bit scary,
redirect to current directory looks safer and does not try to escape sandbox.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@krader1961
Copy link
Contributor

Trying to redirect something to / looks a bit scary

No more than trying to open any directory for writing, including . (CWD). If your OS allows you to do that rather than return an error condition then your OS is badly broken. It doesn't matter if its root or the CWD. Having said that it doesn't really matter what directory we open since all we're verifying is that fish correctly handles the error indication the OS returns. The CWD works fine for that purpose so I'll merge this.

@krader1961 krader1961 closed this Aug 17, 2017
@gyakovlev gyakovlev deleted the do-not-redirect-to-slash branch August 17, 2017 17:35
@zanchey zanchey added this to the fish 2.7.0 milestone Aug 19, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants