Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt completions #4347

Closed
wants to merge 5 commits into from
Closed

Add sbt completions #4347

wants to merge 5 commits into from

Conversation

@laughedelic
Copy link
Contributor

@laughedelic laughedelic commented Aug 21, 2017

Description

Added completions for sbt (Build tool for Scala projects).

TODOs:

  • User-visible changes noted in CHANGELOG.md
laughedelic added 5 commits Aug 21, 2017
Also fixed sublist indentation and removed periods for formtatting consistency
Because they are not combinable with other commands and need an argument.
Other commands shouldn't be suggested as args for new or client command
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Aug 30, 2017

Squash-merged as a43da01. Thanks!!

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Aug 30, 2017

Err, I stripped out the CHANGELOG.md changes because I thought we constructed those at release time, but maybe that was my mistake.

@laughedelic laughedelic deleted the laughedelic:patch-1 branch Aug 30, 2017
@laughedelic
Copy link
Contributor Author

@laughedelic laughedelic commented Aug 30, 2017

Thanks.

Err, I stripped out the CHANGELOG.md changes because I thought we constructed those at release time, but maybe that was my mistake.

No problem. It was on the pull-request template TODO list, so I added it. Actually, there's a little more in eb05c39: it fixes markdown list indentation of the other completions.

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Aug 30, 2017

Ooh, nice. cherry-picked eb05c39 as 75dd852, thanks!

@zanchey
Copy link
Member

@zanchey zanchey commented Aug 30, 2017

We've been encouraging everyone to keep the CHANGELOG up to date - it was getting to the point where it was taking days to write up and delaying the release.

@laughedelic
Copy link
Contributor Author

@laughedelic laughedelic commented Aug 30, 2017

I think it's a very good practice. Although when many people edit same document, it's helpful to have some (at least formatting) guidelines.

@zanchey zanchey added this to the fish 2.7.0 milestone Sep 2, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.