Implement Linear glob match #4094 #4579
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Noted in #4094 that glob expansion is exponential. A near linear implementation is discussed in this article on glob expansion in various shells and platforms.
Changes in
wildcard.cpp
:The function that is responsible for this behavior is
wildcard_match
and itswildcard_match_internal
which matches the wildcard recursively with the string. I changed it to the near linear implementation discussed in the article.The wildcard
"**"
is not affected by this function becausewildcard_expand_string
is the one that is responsible for it and it is still doing it recursively.tested using:
a*
)Fixes issue #4094