Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overzealous cd tab completion #4649

Closed
wants to merge 1 commit into from

Conversation

@mtbrock
Copy link
Contributor

@mtbrock mtbrock commented Jan 8, 2018

Description

Changed cd completion to differentiate between cd autosuggest and cd tab
completion. cd autosuggest will find deepest unique hierarchy and cd tab
completion will not.

Fixes issue #4402

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
Changed cd completion to differentiate between cd autosuggest and cd tab
completion. cd autosuggest will find deepest unique hierarchy and cd tab
completion will not.

Issue fish-shell#4402
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Jan 8, 2018

Looks really good! I'll test and then merge if it checks out. Thanks for doing this!

Loading

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Jan 9, 2018

Merged as bf63e06, thanks!

Loading

ridiculousfish added a commit that referenced this issue Jan 9, 2018
@mtbrock
Copy link
Contributor Author

@mtbrock mtbrock commented Jan 9, 2018

Glad I could help

Loading

@zanchey zanchey added this to the fish-3.0 milestone Jan 9, 2018
@Wazzaps
Copy link

@Wazzaps Wazzaps commented Dec 28, 2018

Actually I loved this feature. Is it possible to have this as a feature flag?

Loading

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Jan 9, 2019

Not suitable for a feature flag, but this might be writable as a custom completion if someone wants to try.

Loading

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants