Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed suspend --force conditions #4672

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Fixed suspend --force conditions #4672

merged 1 commit into from
Jan 19, 2018

Conversation

tie
Copy link
Contributor

@tie tie commented Jan 18, 2018 •
edited
Loading

Description

  • Fixed bug introduced in 772e3556#diff-a56ac7fe3d565eb56b49cb0014025616R3
    status --is-interactive and not status --is-login is interpreted as a single command and exits with non-zero code, therefore if condition is always true.
  • Rewrote with argparse
  • suspend shows how to resume only in interactive shell

TODOs:

  • [N/A] Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@tie tie changed the title Fixed suspend --force conditions Fixed suspend --force conditions Jan 18, 2018
@faho faho added the bug Something that's not working as intended label Jan 19, 2018
@faho faho added this to the fish-3.0 milestone Jan 19, 2018
@faho faho merged commit 6066e24 into fish-shell:master Jan 19, 2018
@faho
Copy link
Member

faho commented Jan 19, 2018

Wow, I did not notice that! Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
fish 3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tie @faho