New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the size of completions page to show the entire multi-line prompt #4702

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@s417-lama
Copy link
Contributor

s417-lama commented Feb 4, 2018

Description

Problem

When editing multi lines and selecting completions, the page of completions hides the lines except the bottom line.
I think it is uncomfortable not to be able to see the entire lines even after selecting the completion.

What I changed

I changed to show the entire lines when selecting completions.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
@ridiculousfish

This comment has been minimized.

Copy link
Member

ridiculousfish commented Feb 4, 2018

Thanks, nice fix! I'm going to merge it as is, but then I will change it to use a simple newline count instead of the heavyweight prompt layout machinery.

Merged as 27c1c06 - thanks!

@ridiculousfish ridiculousfish added this to the fish-3.0 milestone Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment