Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose completions #4731

Closed
wants to merge 1 commit into from

Conversation

Hunsu
Copy link
Contributor

@Hunsu Hunsu commented Feb 17, 2018

I'm just moving the completions from https://github.com/brgmnn/fish-docker-compose. I think there no license issues.
I notified the author here brgmnn/fish-docker-compose#15.

TODOs:

I saw that the completions hangs when completing a subcommand: for example docker-compose up . Can you help me debug the issue?

I'm just moving the completions from https://github.com/brgmnn/fish-docker-compose. I think there no license issues.
I notified the author here brgmnn/fish-docker-compose#15.
@zanchey
Copy link
Member

zanchey commented Feb 18, 2018

docker-compose completions are shipped by the upstream Docker Compose project - see https://github.com/docker/compose/tree/master/contrib/completion/fish

This is something we actively encourage as it avoids problems with version mismatch between options offered by commands and our completions.

If there's improvements to be made, could I ask that you submit them to the maintainers of Docker Compose?

@zanchey zanchey closed this Feb 18, 2018
@faho faho mentioned this pull request Jul 6, 2018
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants