-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flags #4940
Feature flags #4940
Commits on May 6, 2018
-
This introduces a new type features_t that exposes feature flags. The intent is to allow a deprecation/incremental adoption path. This is not a general purpose configuration mechanism, but instead allows for compatibility during the transition as features are added/removed. Each feature has a user-presentable short name and a short description. Their values are tracked in a struct features_t. We start with one feature stderr_nocaret, but it's not hooked up yet.
Configuration menu - View commit details
-
Copy full SHA for 14f766b - Browse repository at this point
Copy the full SHA 14f766bView commit details -
Add status subcomannds: features and test-feature
This teaches the status command to work with features. 'status features' will show a table listing all known features and whether they are currently on or off. `status test-feature` will test an individual feature, setting the exit status to 0 if the feature is on, 1 if off, 2 if unknown.
Configuration menu - View commit details
-
Copy full SHA for 782cae2 - Browse repository at this point
Copy the full SHA 782cae2View commit details -
Allow setting feature flags on the command line
This introduces a new command line option --features which can be used for enabling or disabling features for a particular fish session. Examples: fish --features stderr-nocaret fish --features 3.0,no-stderr-nocaret fish --features all Note that the feature set cannot be changed in an existing session.
Configuration menu - View commit details
-
Copy full SHA for 8a96f28 - Browse repository at this point
Copy the full SHA 8a96f28View commit details -
Bring back caret redirections under a feature flag
This partially reverts 5b489ca, with carets acting as redirections unless the stderr-nocaret flag is set. This flag is off by default but may be enabled on the command line: fish --features stderr-nocaret
Configuration menu - View commit details
-
Copy full SHA for 902af26 - Browse repository at this point
Copy the full SHA 902af26View commit details -
Set features from the environment
This enables users to opt in (or out) of specific features by setting the fish_features environment variable. For example `set -U fish_features stderr-nocaret` to opt into removing the caret redirection.
Configuration menu - View commit details
-
Copy full SHA for d3201ad - Browse repository at this point
Copy the full SHA d3201adView commit details -
Add a qmark-noglob feature flag
This adds a feature flag for controlling whether question marks are globs. It is not yet hooked up.
Configuration menu - View commit details
-
Copy full SHA for dc8d603 - Browse repository at this point
Copy the full SHA dc8d603View commit details -
Feature flag support for ? wildcard
This partially reverts 6e56637 and fish-shell#4520 by bringing back the ? wildcard, guarded by the qmark-noglob feature flag.
Configuration menu - View commit details
-
Copy full SHA for 762c31b - Browse repository at this point
Copy the full SHA 762c31bView commit details -
This is a convenience over fish_features().test()
Configuration menu - View commit details
-
Copy full SHA for 4194b4e - Browse repository at this point
Copy the full SHA 4194b4eView commit details -
Remove some references to ^ redirection from the docs
Replace these with 2>
Configuration menu - View commit details
-
Copy full SHA for 87eb073 - Browse repository at this point
Copy the full SHA 87eb073View commit details -
Configuration menu - View commit details
-
Copy full SHA for d623ac5 - Browse repository at this point
Copy the full SHA d623ac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 060643a - Browse repository at this point
Copy the full SHA 060643aView commit details