Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4926 #5011

Closed
wants to merge 1 commit into from
Closed

Issue #4926 #5011

wants to merge 1 commit into from

Conversation

@swayamraina
Copy link
Contributor

@swayamraina swayamraina commented May 27, 2018

Suppress update of CMD_DURATION environment variable if no command is requested for execution

Description

Environment variable CMD_DURATION will not be updated unless the user wishes to execute a non-empty command inside the fish shell.

Fixes issue #4926

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
Suppress update of CMD_DURATION environment variable if no command is requested for execution
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented May 27, 2018

Merged as eb0539a with some updating of commit message. Thanks! Congrats on first contribution!

Loading

@ridiculousfish ridiculousfish added this to the fish-3.0 milestone May 27, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants