New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xclip support for clipboard copy and paste functions #5020

Merged
merged 1 commit into from Jun 2, 2018

Conversation

Projects
None yet
2 participants
@kewlfft
Copy link
Contributor

kewlfft commented Jun 2, 2018

Description

New feature.
Basic, add xclip support for clipboard copy and paste functions

Fixes issue #5017

TODOs:

May need to indicate an optional dependency to xclip and provide information in the wiki. Let me know if I can help. Nothing else has been done so far.

@faho faho merged commit ebc5e18 into fish-shell:master Jun 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@faho faho added the enhancement label Jun 2, 2018

@faho faho added this to the fish-3.0 milestone Jun 2, 2018

@faho

This comment has been minimized.

Copy link
Member

faho commented Jun 2, 2018

Merged, thanks!

May need to indicate an optional dependency to xclip and provide information in the wiki.

So far I've not been sure where we should document this kind of stuff. So far, we haven't documented the xsel or pbcopy/pbpaste paths either. Would a note buried somewhere in the docs really help? Would an "optional dependencies" section? Or should we add separate sections for these _commands (i.e. a fish_clipboard_paste and a fish_clipboard_copy section in the html/man page)?

Neither of those sounds particularly effective to me - I figured people would check type fish_clipboard_copy, and see that it's quite self-explanatory. Maybe my assumption is wrong though.

Where would you expect this documentation to be? I don't really want to use the github wiki for this if we can avoid it, though.

@kewlfft

This comment has been minimized.

Copy link
Contributor

kewlfft commented Jun 3, 2018

Personally I didn't look into the manual or the wiki, I directly checked fish_clipboard_copy which is the most efficient way. It is the best way to let people understand exactly what it does and contribute if they think they can do better I think.
I vote for no documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment