vi key bindings: fix "*y

[raichoo]

Description

I've had some issues with the "*y" key binding, apparently something goes wrong here when trying to paste something into my clipboard, it simply didn't do anything and the visual selection started to get confused (selection didn't really end but persisted throughout later commands). I've come up with this as a fix. Not quite sure if this exposes a deeper issue that is going on here, but for now this makes it work for me.

[raichoo]

Huh, interestingly this does not seem to fix the issue completely. I've added this to my config.fish and it worked, while the above PR does not.

  bind -e -M visual '"*y'
  bind -M visual -m default '"*y' 'commandline -s | xsel -p; commandline -f end-selection force-repaint'

I'm a bit confused at the moment because I don't seem to get that change to show up properly anywhere in my installation. I'm obviously doing something wrong here. This might be a working fix but I'm currently at odds with the build system or whatever.

[raichoo]

Okay, seems to work. For some reason gmake install didn't overwrite the fish_vi_key_bindings.fish. My bad, sorry for the noise.

[faho]

Ooh, wow, that's not just something that doesn't work, it also shouldn't.

I think it actually did at one point - I faintly remember that we changed when something is taken as a bind function sometime in the 2.2 or 2.3 cycle - but it's quite unclean and prone to errors.

@raichoo: If you'd like, there's at least two more of these in the vi bindings, and the shared and default ones could also have some:

    #bind -m insert o "commandline -a \n" down-line force-repaint
    #bind -m insert O beginning-of-line "commandline -i \n" up-line force-repaint # doesn't work

which even says that it doesn't work and is commented....

and

    bind '"*P' backward-char "commandline -i ( xsel -p; echo )[1]"

[raichoo]

I'm having issues getting these to work properly. For some reason whenever I'm doing a commandline -i x after moving the cursor around (e.g. using commandline -f end-of-line) fish will insert the character at the previous position and not the updated one.

[krader1961]

@raichoo You can't get it to work because of issue #3031.

[raichoo]

Ah thanks, that makes sense.

[raichoo]

So I guess the other commands should be addressed once there is a solution for this issue. I don't see how to fix these motions as it is right now. Reading in the whole input and replacing it with the modified version doesn't seem like a feasible solution for me.

[faho]

Let's merge this as it is, then!