Add till/repeat/reverse jump bindings #5140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cttttt
commented
Aug 11, 2018
src/reader.cpp
Outdated
| if (precision == jump_precision_t::till) { | ||
| tmp_pos -= step; | ||
| } | ||
| tmp_pos = std::max(tmp_pos, (size_t)0); |
There was a problem hiding this comment.
C/C++ rust is showing
Note to self: size_t is unsigned, so this doesn't make sense. I need to rework this loop else it will skip the first position in el. Perhaps the while (tmp_pos--) loop that was there is the cleanest approach for scanning backward.
cttttt
force-pushed
the
add-till-bindings
branch
from
82d5b56
to
4d6203e
Compare
|
This looks good. I just tried switching to fish but was disappointed by the half-baked vi mode. I'm glad this issue is fixed. I'm planning to try seperating the action/movement bindings and move the state into the core, so we can do stuff like repeated commands through period (.) as in vim. It would also remove redundancy in having to specify df, dt, dF, dT, dw, etc. |
- Add support for: - Jumping to the character before a target. - Repeating the previous jump (same direction, same precision). - Repeating the previous jump in the reverse order. - Enhance vi bindings.
cttttt
force-pushed
the
add-till-bindings
branch
from
4d6203e
to
05e1366
Compare
|
Looks awesome! Merged as 1d68b52. Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gave fish a try and it's amazing, but the vi bindings are only almost perfect.
I'm hardwired to use
;and,to repeat previous jumps in vi and bash's vi-mode, but these seem to be missing in fish. The way T and t bindings are implemented in the fish script, it's kinda difficult to persist enough to cleanly implement repeats/reversals of all varieties of jump, so I moved all jump motions directly into fish.These changes:
TODOs: