Fix crash when /etc/{fstab,hosts} is unreadable. #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks fine, but does fish actually crash? It shouldn't crash, even if a completion returns garbage. |
|
Unfortunately, it does. In the excerpt below, after typing 'ssh wor' I pressed , and it died. % ssh worfish: An error occurred while redirecting file '/etc/fstab' |
|
Ok, the crash occurs when a redirecting to a function fails, e.g. |
|
The crash should be fixed as c9b4163 |
|
I think your fix is good to include as well, so I merged it with rebase as 286bef5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My /etc/fstab is 0700, and fish crashed when tab-completing hostnames due to this.