Add backtraces to test errors #5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a remainder from when we used to speak of "eval errors".
`test` is a common source of problems, and with the current system they can be quite hard to find. So we print a backtrace with line numbers and all.
|
Sweet, makes sense to me and changes look good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As you know,
testhas some sharp edges.And worst of all, whenever you have hit one of them in a large script, it's hard to find because it'll only tell you "Missing argument at index 2" or "\tThe argument is invalid: 'w'".
This adds a backtrace to that, like our other builtins, so you can find the darn bugger.
TODOs: