Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $PWD to retrieve the current directory in __fish_move_last. #6395

Merged
merged 1 commit into from Dec 7, 2019

Conversation

pcc
Copy link
Contributor

@pcc pcc commented Dec 6, 2019

Description

(command pwd) uses the system's implementation of pwd. At least the GNU
coreutils implementation defaults to -P, which resulted in symlinks being
expanded when switching between directories with nextd/prevd.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

(command pwd) uses the system's implementation of pwd. At least the GNU
coreutils implementation defaults to -P, which resulted in symlinks being
expanded when switching between directories with nextd/prevd.
@faho faho added this to the fish 3.1.0 milestone Dec 7, 2019
@faho
Copy link
Member

faho commented Dec 7, 2019

Yeah, that goes back to 73a9c8b (from 2006!), when fish didn't have a pwd builtin, but a pwd function that pretty-printed the pwd (replaced $HOME with ~ and removed /private).

Which in retrospect sounds like a terrible idea.

Merging, thanks!

@faho faho merged commit 6dc4ac6 into fish-shell:master Dec 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants