Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git prompt: Fix shell hang when in detached HEAD repo #6936

Closed
wants to merge 1 commit into from
Closed

git prompt: Fix shell hang when in detached HEAD repo #6936

wants to merge 1 commit into from

Conversation

ivellioscolin
Copy link

Setting illegal ASCII character will cause the shell hang.
Use ASCII ... instead.

Signed-off-by: Colin Xu colin.xu@gmail.com

Description

Talk about your changes here.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

Setting illegal ASCII character will cause the shell hang.
Use ASCII ... instead.

Signed-off-by: Colin Xu <colin.xu@gmail.com>
@faho
Copy link
Member

faho commented Apr 23, 2020

Duplicate of #6736

@faho faho marked this as a duplicate of #6736 Apr 23, 2020
@faho faho closed this Apr 23, 2020
@faho
Copy link
Member

faho commented Apr 23, 2020

Note: You should really really really, pretty please with a cherry on top, set a unicode-capable locale.

That fish had issues with a non-unicode capable locale is #6736.

The unicode ellipsis is so much nicer than the "..." that we really want it by default.

@ivellioscolin
Copy link
Author

Gotcha!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants