Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show smartcase-matches if there is no exact match #7743

Closed
wants to merge 1 commit into from
Closed

Only show smartcase-matches if there is no exact match #7743

wants to merge 1 commit into from

Conversation

krobelus
Copy link
Member

This makes smartcase completion a bit less smart. I'm not sure if that's okay.
This allows to remove the workaround for #7738

@krobelus
Only show smartcase-matches if there is no exact match
ce44173 
This makes smartcase completion a bit less smart. I'm not sure if that's okay.
This allows to remove the workaround for fish-shell#7738
@faho
Copy link
Member

faho commented Feb 25, 2021

I'm assuming this is for 3.3?

@krobelus
Copy link
Member Author

Yeah that's probably safer. I'm not sure which behavior we want.

Actually, I forgot to disclose: the reason why I made this was that with #7744, d0a8493 no longer works as fix for #7738.
It might be possible to tweak it though, I need to look into that.

@krobelus krobelus added this to the fish 3.3.0 milestone Feb 25, 2021
@krobelus
Copy link
Member Author

This is no longer necessary with the updated #7744.

@krobelus krobelus closed this Mar 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
will-not-implement
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krobelus @faho