Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct case in completion pager #7744

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Use the correct case in completion pager #7744

merged 1 commit into from
Mar 21, 2021

Commits on Mar 21, 2021

  1. Use the correct case in completion pager 

    Consider

	$ complete -c foo -a 'aab aaB' -f
	$ foo A<TAB>

since 28d67c8 we would insert the common prefix AND show the pager.
Due to case-insensitive comparison, "b/B" was considered to be part
of the prefix. Since the prefix is added to each pager item [1]
we get wrong results. Fix this by removing the insensitive comparison
between completions - I don't think it was of much use anyway.
Commandline tokens are still matched case-insensitively, this is
just about completions.

Test this by running interactive fish inside tmux (pexpect's terminal
emulation not have enough capabilities).  Also add tests for recent
interactive regressions fish-shell#7526 and fish-shell#7738.

Closes fish-shell#3978

[1]: b38a23a would solve this differently by giving every pager item
its own prefix, but was reverted since it needs more fixes.
    @krobelus
    krobelus committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    a4d0fdd View commit details
    Browse the repository at this point in the history