Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make help and fish_config work on Chrome OS #7789

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Make help and fish_config work on Chrome OS #7789

merged 2 commits into from
Mar 7, 2021

Commits on Mar 7, 2021

  1. Make help and fish_config work on Chrome OS

    When `fish` is running in the Chrome OS Linux VM (Crostini),
    both `help` and `fish_config` opened a "file not found"
    page. That is because on Crostini, `BROWSER` is usually set to
    `garcon-url-handler`, which opens URLs in the host OS Chrome
    browser. That browser lacks access to the Linux file system.
    
    This commit fixes these commands. `help` now opens the URL on
    www.fishshell.com.  `fish_config` now opens the URL for the
    server it starts. Previously, it opened a local file that
    redirects to the same URL.
    
    In the case of `help`, the situation could be improved further
    by starting a web server to serve help. I don't know of another
    way to access `/share/fish` from outside the VM without user
    intervention, and I think that might be a part of the security
    model for the Crostini VM.
    
    It's hard to write a test for this. I checked that `help math`,
    `python2 webconfig.py`, and `python3 webconfig.py` work on my
    machine running in Crostini.
    ilyagr committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    9e34e90 View commit details
    Browse the repository at this point in the history
  2. Incorporate black suggestions & rearrange imports slightly

    This isn't really necessary, but it makes the file look nicer to
    my eyes. Let me know if you want me to remove this commit.
    ilyagr committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    98b6903 View commit details
    Browse the repository at this point in the history