complete: fix condition to suppress variable autocompletion #9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep it's a good fix! The intention of this code is to not autosuggest with a bare $. Consider: fish has no idea what the user will type next, so it offers nothing at all. This happens to work with a single $, but the test fails for more than one: here fish autosuggests something (the first variable, alphabetically) and the reason is the bug you found. Very well spotted. |
|
I don't think this is worth a changelog but it's a good fix. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code behave like the comment describes; if that's not actually the intended behaviour, I'll change the comment instead.