Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some german translations #9824

Merged
merged 3 commits into from Jun 3, 2023
Merged

added some german translations #9824

merged 3 commits into from Jun 3, 2023

Conversation

Z3hka
Copy link

@Z3hka Z3hka commented Jun 1, 2023

Description

I read a complaint about missing translators for fish on mastodon so i translated a few strings into German

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(doing review in english so that others have an idea what I'm doing)

This looks nice, overall, but I have some suggestions and found some typos.

po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Outdated Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Outdated Show resolved Hide resolved
Copy link
Contributor

@Xiretza Xiretza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, a couple nits from me as well. Thanks!

po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved

#: src/env_dispatch.cpp:577
msgid "TERM environment variable not set."
msgstr ""
msgstr "TERM Umgebungsvariable nicht gesetzt."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar nit:

Suggested change
msgstr "TERM Umgebungsvariable nicht gesetzt."
msgstr "TERM-Umgebungsvariable nicht gesetzt."

po/de.po Show resolved Hide resolved
po/de.po Outdated Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Outdated

#: src/pager.cpp:45
msgid "search: "
msgstr ""
msgstr "suche: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the label for the pager search field, I think the noun makes more sense than the imperative verb here.

Suggested change
msgstr "suche: "
msgstr "Suche: "

po/de.po Show resolved Hide resolved
po/de.po Show resolved Hide resolved
po/de.po Outdated
@@ -5733,7 +5728,7 @@ msgstr "Architektur festlegen"

#: /tmp/fish.i8YroE/implicit/share/completions/apt-file.fish:13
msgid "Set sources.list file"
msgstr "sources.list-Datei angeben"
msgstr "Sources.list-Datei festlegen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this actually has to be named sources.list, maybe put it in quotes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was me following the linter to blindly :D

@faho
Copy link
Member

faho commented Jun 1, 2023

Okay, that last commit is a bit of a mess.

It includes thousands of changes of the form

-#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:2
-#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:5
+#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:2 /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:5

which makes it very hard to find the actual changes. If you can, it would be cool to remove those bits and leave the actual changes.

@Z3hka
Copy link
Author

Z3hka commented Jun 1, 2023

I guess some cross-os linebreak incompatiliblities happene. I force-pushed the commit before it and will add the changes back later

@faho
Copy link
Member

faho commented Jun 3, 2023

Okay, I've now removed the unnecessary changes, and I'm going to merge this now.

If I've missed anything, which is easily possible because I searched through 15000 lines for changed msgstrs, feel free to yell or open another PR!

@faho faho merged commit a0a2475 into fish-shell:master Jun 3, 2023
7 checks passed
@zanchey zanchey modified the milestones: fish 3.7.0, fish 3.6.2 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants