New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added some german translations #9824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(doing review in english so that others have an idea what I'm doing)
This looks nice, overall, but I have some suggestions and found some typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a couple nits from me as well. Thanks!
|
||
#: src/env_dispatch.cpp:577 | ||
msgid "TERM environment variable not set." | ||
msgstr "" | ||
msgstr "TERM Umgebungsvariable nicht gesetzt." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar nit:
msgstr "TERM Umgebungsvariable nicht gesetzt." | |
msgstr "TERM-Umgebungsvariable nicht gesetzt." |
po/de.po
Outdated
|
||
#: src/pager.cpp:45 | ||
msgid "search: " | ||
msgstr "" | ||
msgstr "suche: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the label for the pager search field, I think the noun makes more sense than the imperative verb here.
msgstr "suche: " | |
msgstr "Suche: " |
po/de.po
Outdated
@@ -5733,7 +5728,7 @@ msgstr "Architektur festlegen" | |||
|
|||
#: /tmp/fish.i8YroE/implicit/share/completions/apt-file.fish:13 | |||
msgid "Set sources.list file" | |||
msgstr "sources.list-Datei angeben" | |||
msgstr "Sources.list-Datei festlegen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this actually has to be named sources.list
, maybe put it in quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was me following the linter to blindly :D
Okay, that last commit is a bit of a mess. It includes thousands of changes of the form -#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:2
-#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:5
+#: /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:2 /tmp/fish.i8YroE/explicit/share/functions/fish_delta.fish:5 which makes it very hard to find the actual changes. If you can, it would be cool to remove those bits and leave the actual changes. |
I guess some cross-os linebreak incompatiliblities happene. I force-pushed the commit before it and will add the changes back later |
Okay, I've now removed the unnecessary changes, and I'm going to merge this now. If I've missed anything, which is easily possible because I searched through 15000 lines for changed |
Description
I read a complaint about missing translators for fish on mastodon so i translated a few strings into German
TODOs: