Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i o for unzip #9850

Merged
merged 3 commits into from Jun 18, 2023
Merged

Add i o for unzip #9850

merged 3 commits into from Jun 18, 2023

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Jun 18, 2023

Description

use grep string match to test the -I and -O before show completion.

Fixes issue #9849

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

share/completions/unzip.fish Outdated Show resolved Hide resolved
@faho faho merged commit bab8fb9 into fish-shell:master Jun 18, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Jun 18, 2023

Merged, thanks!

@zanchey zanchey added this to the fish 3.6.2 milestone Jun 19, 2023
faho pushed a commit that referenced this pull request Oct 1, 2023
* add -I -O for unzip

* for different distroes.

* avoid grep

(cherry picked from commit bab8fb9)
@asukaminato0721 asukaminato0721 deleted the add-I-O-for-unzip branch February 16, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants