Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: correct small grammatical error in read.rst #9915

Merged
merged 1 commit into from Jul 26, 2023

Conversation

asfaltboy
Copy link
Contributor

Description

Just noticed this sentence doesn't make sense (the construct is typically used as 'while something, something else' but we just end the sentence early); I assumed it intended to reference the while command, so I attempted to link to it to help the reader to read more if they wished so.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho merged commit c56f9e1 into fish-shell:master Jul 26, 2023
6 of 7 checks passed
@faho
Copy link
Member

faho commented Jul 26, 2023

The intended construct is "The following code stores the value 'hello' in $foo: (some code), while this code here can be used to read line-by-line: (some more code)".

Which is a tad awkward so let's use this PR instead. Thanks, merged!

@faho faho added the docs An issue/PR that touches or should touch the docs label Jul 26, 2023
@faho faho added this to the fish 3.7.0 milestone Jul 26, 2023
@zanchey zanchey modified the milestones: fish 3.7.0, fish 3.6.2 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue/PR that touches or should touch the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants