fix __fish_list_current_token not recognizing ~ as $HOME

[Axlefublr]

No description provided.

[Axlefublr]

it's not gonna hurt if I elaborate: I'd expect cd ~/.config to display the contents of .config, but it doesn't because it doesn't recognize ~ as home, which is incredibly annoying

I will argue that not seeing dotfiles and dotdirectories is also annoying, but I can see how not using the -A flag for the ls is a design choice. However I'm gonna jump up thrice if you agree that it's a good idea to change the ls in there to ls -A instead

[henrikhorluck]

I was wrong, I did not have this keybound

I might be misunderstanding where this is used but I assume you are talking about tab-completion?

If that is the case I cannot reproduce your error, even in sh -c 'env HOME=$(mktemp -d) XDG_CONFIG_HOME= fish' (note you probably want to add another file to your temp home's .config there, only ./config/fish exists by default).

Tab-completing with cd ~/.config/ already correctly displays the contents of ~/.config/ for me on master, and it also works on 3.6.1. This works regardless of whether AppleShowAllFiles is set or not (I am on macOS)

Okay so the error is reproducible as

sh -c 'env HOME=$(mktemp -d) XDG_CONFIG_HOME= fish'
cd ~
mkdir ~/.config/test
touch hello.txt
cd ~/.config # and then enter keybind for __fish_list_current_token, which is ALT + L by default
# should print "test" and "fish", but instead prints "hello.txt"

I don't think we should special-case ~ here, $HOME/.config also does not work, it is more sensible to perform full variable-expansion akin to how tab-completion works

[Axlefublr]

what's completely hilarious is that "$HOME/.config" does work, but $HOME/.config doesn't

the former being a situation you would practically never find yourself in

[Axlefublr]

also yeah I agree. ideally we take the token and expand it like you would by pressing tab

maybe you're doing something like ~/.c/k intending to press tab to expand it to ~/.config/kitty

making list-current-token support that would be ideal

but honestly I don't even need ideal, I just want not ridiculous

[zanchey]

The full right answer here would be #751, probably as a subcommand of path.

[faho]

This is fine as a stop gap. Thanks, merged!

[Axlefublr]

Thank you for merging!

Was scared that this was going to be a situation of "we can't do it perfectly so we won't do it at all", so it's nice to see the feature being merged at least in this simplified fashion for the time being